uranusjr commented on code in PR #46512:
URL: https://github.com/apache/airflow/pull/46512#discussion_r1948437831
##########
airflow/models/dag.py:
##########
@@ -1782,6 +1787,9 @@ def create_dagrun(
:meta private:
"""
logical_date = timezone.coerce_datetime(logical_date)
+ # For manual runs where logical_date is None, ensure no data_interval
is set.
+ if logical_date is None:
+ data_interval = None
Review Comment:
This should be ensured at the _call site_. This function can raise an error
if data interval is provided when logical date is None, although I think even
that’s not necessary. It does not make sense, but we can allow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
