shahar1 commented on code in PR #46584:
URL: https://github.com/apache/airflow/pull/46584#discussion_r1951582645
##########
airflow/models/skipmixin.py:
##########
@@ -120,23 +74,11 @@ def skip(
return
task_ids_list = [d.task_id for d in task_list]
- SkipMixin._set_state_to_skipped(dag_id, run_id, task_ids_list, session)
Review Comment:
I wonder if we even need to preserve this functionality - overall it looks
like a short cut to set tasks to skipped before `NotPreviouslySkippedDep`
handles it (breaks single responsibility?), and surely it won't work when
there's no direct access to the DB from the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
