shahar1 commented on code in PR #46584:
URL: https://github.com/apache/airflow/pull/46584#discussion_r1951451483


##########
airflow/ti_deps/deps/not_previously_skipped_dep.py:
##########
@@ -49,46 +48,47 @@ def _get_dep_statuses(self, ti, session, dep_context):
         finished_task_ids = {t.task_id for t in finished_tis}
 
         for parent in upstream:
-            if isinstance(parent, SkipMixin):

Review Comment:
   ~If we retain it - we also need to check whether it's a [mapped 
operator](https://github.com/apache/airflow/pull/44925#discussion_r1884624755), 
otherwise we have issues in that area~
   
   Need to double check this statement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to