Dong-yeong0 commented on code in PR #47709:
URL: https://github.com/apache/airflow/pull/47709#discussion_r1994029005
##########
airflow/models/connection.py:
##########
@@ -256,6 +256,9 @@ def get_uri(self) -> str:
if self.conn_type:
uri = f"{self.conn_type.lower().replace('_', '-')}://"
+ if self.conn_type == "postgres":
+ driver = self.extra_dejson.get("postgres_driver", "postgres")
+ uri = uri.replace("postgres://", f"{driver}://", 1)
Review Comment:
Thank you for pointing out #38831 👍
I see that it addresses the `get_uri()` issue.
I'll review its changes and check if customizing the `designator` via
`extra` still adds value.
If needed, I'll adjust my implementation accordingly.
Thanks again for your insights! 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]