potiuk commented on PR #47709: URL: https://github.com/apache/airflow/pull/47709#issuecomment-2726907062
> @potiuk My intention was to allow `get_uri()` in the Connection model to directly return a SQLAlchemy-compatible URI. However, I now see that my approach was incorrect. > > If using `sqlalchemy_url` is the proper way, would it be better to update the get_uri() in `models/connection.py` docstring instead? > > I can modify the PR accordingly. Yep. That's better approach. It did cause confusion before so you are not the first one. It would be great to have it better decribed in docstring but also maybe even in documentation if we find a good place ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
