jason810496 commented on code in PR #47709:
URL: https://github.com/apache/airflow/pull/47709#discussion_r1997457478


##########
airflow/models/connection.py:
##########
@@ -256,6 +256,9 @@ def get_uri(self) -> str:
 
         if self.conn_type:
             uri = f"{self.conn_type.lower().replace('_', '-')}://"
+            if self.conn_type == "postgres":

Review Comment:
   Agree with potiuk's comment.
   > I really appreciate your suggestion👍, but I think I need to change my 
approach.
   
   Sure, look forward for your change.



##########
airflow/models/connection.py:
##########
@@ -256,6 +256,9 @@ def get_uri(self) -> str:
 
         if self.conn_type:
             uri = f"{self.conn_type.lower().replace('_', '-')}://"
+            if self.conn_type == "postgres":

Review Comment:
   Agree with potiuk's comment.
   > I really appreciate your suggestion👍, but I think I need to change my 
approach.
   
   Sure, look forward for your change, thanks !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to