bugraoz93 commented on code in PR #50837:
URL: https://github.com/apache/airflow/pull/50837#discussion_r2098579139
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -502,7 +502,7 @@ def list(
) -> JobCollectionResponse | ServerResponseError:
"""List all jobs."""
try:
- params = {"limit": limit, "job_type": job_type, "hostname":
hostname, "is_alive": is_alive}
+ params = {limit: limit, "job_type": job_type, "hostname":
hostname, is_alive: is_alive}
Review Comment:
```suggestion
params = {"limit": limit, "job_type": job_type, "hostname":
hostname, "is_alive": is_alive}
```
Key of `limit` shouldn't be an integer here, same for `is_alive` shouldn't
be a bool.
We should include all the filters here
https://github.com/apache/airflow/blob/b566a0b57f48beefb5a6aa33c439c4630ff14197/airflow-core/src/airflow/api_fastapi/core_api/routes/public/job.py#L56-L102
We shouldn't include the limit here since we should either filter or return
the full result. See the above endpoint, it is very similar to all the list
methods on the API side. It will be very similar to the return of all entities
that you are working on. We shouldn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
