Prab-27 commented on code in PR #50837: URL: https://github.com/apache/airflow/pull/50837#discussion_r2107663968
########## airflow-core/src/airflow/api_fastapi/core_api/routes/public/job.py: ########## @@ -44,9 +45,25 @@ from airflow.jobs.job import Job from airflow.utils.state import JobState +if TYPE_CHECKING: + from sqlalchemy.sql import Select + job_router = AirflowRouter(tags=["Job"], prefix="/jobs") +class IsAliveFilter(BaseParam[bool]): Review Comment: Yes, I agree with you, but we don’t have any Filter class in parameters.py, so I implemented it. Since parameters.py contains common parameters, I added it here in Jobs, similar to how the OnlyActiveFilter class is used in assets. I believe all parameters are passed through their related filters, as shown in the code you shared. So, I implemented it this way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
