bugraoz93 commented on code in PR #50837: URL: https://github.com/apache/airflow/pull/50837#discussion_r2107620719
########## airflow-core/src/airflow/api_fastapi/core_api/routes/public/job.py: ########## @@ -44,9 +45,25 @@ from airflow.jobs.job import Job from airflow.utils.state import JobState +if TYPE_CHECKING: + from sqlalchemy.sql import Select + job_router = AirflowRouter(tags=["Job"], prefix="/jobs") +class IsAliveFilter(BaseParam[bool]): Review Comment: I am not sure we need this since we can filter with a boolean value :thinking: I don't think we need this, it can be a boolean filter on the CTL? Even if we need it should be under the `parameters.py`. https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/api_fastapi/common/parameters.py ########## airflow-core/src/airflow/api_fastapi/core_api/routes/public/job.py: ########## @@ -78,6 +95,7 @@ def get_jobs( "executor_class", "hostname", "unixname", Review Comment: I don't think this is needed, we don't have any sort of feature in the CTL, but good to add this to the CTL in the future after first release. ########## airflow-ctl/src/airflowctl/api/operations.py: ########## @@ -497,12 +497,10 @@ def create( class JobsOperations(BaseOperations): """Job operations.""" - def list( - self, job_type: str, hostname: str, limit: int, is_alive: bool - ) -> JobCollectionResponse | ServerResponseError: + def list(self, job_type: str, hostname: str) -> JobCollectionResponse | ServerResponseError: Review Comment: Why did we delete the is_alive param? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
