uranusjr commented on code in PR #51638:
URL: https://github.com/apache/airflow/pull/51638#discussion_r2162863155
##########
task-sdk/src/airflow/sdk/definitions/deadline.py:
##########
@@ -179,6 +176,27 @@ class DeadlineReference:
deadline.evaluate_with()
"""
+ class TYPES:
+ """Collection of DeadlineReference types for type checking."""
+
+ # Deadlines that should be created when the DagRun is created.
+ DAGRUN_CREATED = tuple(
+ {
+ ReferenceModels.DagRunLogicalDateDeadline,
+ ReferenceModels.FixedDatetimeDeadline,
+ }
+ )
Review Comment:
Why not just
```suggestion
DAGRUN_CREATED = (
ReferenceModels.DagRunLogicalDateDeadline,
ReferenceModels.FixedDatetimeDeadline,
)
```
Same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
