uranusjr commented on code in PR #51638:
URL: https://github.com/apache/airflow/pull/51638#discussion_r2162860951
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -143,7 +137,7 @@ class BaseDeadlineReference(LoggingMixin, ABC):
def reference_name(cls: Any) -> str:
return cls.__name__
- def evaluate_with(self, **kwargs: Any) -> datetime:
+ def evaluate_with(self, session: Session, interval: timedelta,
**kwargs: Any) -> datetime:
Review Comment:
```suggestion
def evaluate_with(self, *, session: Session, interval: timedelta,
**kwargs: Any) -> datetime:
```
This applies to all `evaluate_with` and `_evaluate_with`. Make these all
keyword-only arguments since they are only used as such, and this avoids
potential future headaches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
