ramitkataria commented on code in PR #51638:
URL: https://github.com/apache/airflow/pull/51638#discussion_r2167830001
##########
airflow-core/tests/unit/models/test_deadline.py:
##########
@@ -91,7 +91,8 @@ def test_add_deadline(self, dagrun, session):
dagrun_id=dagrun.id,
)
- Deadline.add_deadline(deadline_orm)
+ session.add(deadline_orm)
+ session.flush()
Review Comment:
Is it because there's other tests (`test_dagrun_queued_at_deadline`,
`test_dagrun_success_deadline` etc) that would test the writing of deadlines to
the database? If so, I think we should still test that the values were saved
correctly and match the expected result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
