amoghrajesh opened a new pull request, #53627:
URL: https://github.com/apache/airflow/pull/53627
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Problem
Airflow core currently has extensive coupling with task SDK modules,
creating dependencies between task sdk and core, which makes client server
separation a challenge.
## Current State
- Core modules import directly from airflow.sdk.*
- This creates tight coupling between Core scheduler/API and SDK internals
- Makes it difficult to upgrade SDK independently
- Violates the intended architecture where Core should not depend on SDK
internals
## Solution / Prevention of more such imports
Implement Ruff banned-api (https://docs.astral.sh/ruff/rules/banned-api/)
rules to enforce architectural boundaries:
> TID251 is a Ruff linting rule code that gets triggered when code violates
the banned-api rules we set up.
### What's Been Done ✅
- Banned-API Rules Implemented in `airflow-core/pyproject.toml`
- Temporary Exemptions Added
- Architectural Boundary Enforced
- ✅ New violations prevented - any new SDK imports in core will be flagged
- ✅ Clear violation count - 94 files identified that need refactoring,
will hunt down with the help of community (checked using `ruff check --select
TID251`
### What Needs To Be Done 🚧
- Distribute rules to where they belong
- Example, we shouldn't be exempting task SDK imports in amazon provider in
here, move those rules to `providers/amazon/pyproject.toml`
- Begin systematic refactoring of Core files to remove SDK dependencies
(maybe can be done with ruff?. Dont know yet)
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
