kaxil commented on code in PR #53627: URL: https://github.com/apache/airflow/pull/53627#discussion_r2222116833
########## pyproject.toml: ########## @@ -802,6 +802,130 @@ testing = ["dev", "providers.tests", "tests_common", "tests", "system", "unit", # mechanism and whole .pyi is really "type-checking" only "providers/common/sql/src/airflow/providers/common/sql/hooks/sql.pyi" = ["TID253"] +# Allow Task SDK and its tests to import from task SDK +"task-sdk/**" = ["TID251"] + +# devel-common has test utilities, ok to have SDK imports here +"devel-common/**" = ["TID251"] + +# Allow providers to import from Task SDK because they are consumers of the task SDK +"providers/**" = ["TID251"] + +#Ideally, we shouldn't have any imports from airflow-core in the airflow-core tests, but should be OK for now +"airflow-core/tests/**" = ["TID251"] + +# TODO: check usages here, suspicious about these +"scripts/**" = ["TID251"] +"dev/**" = ["TID251"] +"performance/**" = ["TID251"] +"kubernetes-tests/tests/kubernetes_tests/test_kubernetes_pod_operator.py" = ["TID251"] + +# Temporarily allow existing SDK imports in core files while preventing new ones +# TODO: These files need to be refactored to remove SDK coupling +"airflow-core/src/airflow/api/common/mark_tasks.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/core_api/datamodels/assets.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/core_api/datamodels/hitl.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/core_api/datamodels/variables.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/core_api/services/ui/connections.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/core_api/services/ui/grid.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/execution_api/routes/hitl.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py" = ["TID251"] +"airflow-core/src/airflow/api_fastapi/logging/decorators.py" = ["TID251"] +"airflow-core/src/airflow/assets/evaluation.py" = ["TID251"] +"airflow-core/src/airflow/assets/manager.py" = ["TID251"] +"airflow-core/src/airflow/cli/commands/connection_command.py" = ["TID251"] +"airflow-core/src/airflow/cli/commands/task_command.py" = ["TID251"] +"airflow-core/src/airflow/configuration.py" = ["TID251"] +"airflow-core/src/airflow/dag_processing/collection.py" = ["TID251"] +"airflow-core/src/airflow/dag_processing/manager.py" = ["TID251"] +"airflow-core/src/airflow/dag_processing/processor.py" = ["TID251"] +"airflow-core/src/airflow/datasets/metadata.py" = ["TID251"] +"airflow-core/src/airflow/decorators/__init__.py" = ["TID251"] Review Comment: https://github.com/apache/airflow/pull/53629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
