ashb commented on code in PR #53627: URL: https://github.com/apache/airflow/pull/53627#discussion_r2222001564
########## pyproject.toml: ########## @@ -802,6 +802,130 @@ testing = ["dev", "providers.tests", "tests_common", "tests", "system", "unit", # mechanism and whole .pyi is really "type-checking" only "providers/common/sql/src/airflow/providers/common/sql/hooks/sql.pyi" = ["TID253"] +# Allow Task SDK and its tests to import from task SDK +"task-sdk/**" = ["TID251"] Review Comment: This is overly broad -- it ignores _all_ banned imports. Given the number of ignores we need (and the fact that ignoring the rule means we ignore all banned imports, not just the one we want to ignore), perhaps we should instead put these rules in the subfolders `pyproject.toml` instead of the global workspace-wide one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
