abhiips07 commented on code in PR #54494: URL: https://github.com/apache/airflow/pull/54494#discussion_r2282026191
########## providers/google/src/airflow/providers/google/cloud/queues/pubsub.py: ########## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import re +from typing import TYPE_CHECKING + +from airflow.exceptions import AirflowOptionalProviderFeatureException +from airflow.providers.google.cloud.triggers.pubsub import PubsubPullTrigger + +try: + from airflow.providers.common.messaging.providers.base_provider import BaseMessageQueueProvider +except ImportError: + raise AirflowOptionalProviderFeatureException( + "This feature requires the 'common.messaging' provider to be installed in version >= 1.0.1." + ) + +if TYPE_CHECKING: + from airflow.triggers.base import BaseEventTrigger + +# [START queue_regexp] +QUEUE_REGEXP = ( + r"^projects/(?P<project_id>[^/]+)/subscriptions/" + r"(?P<subscription>(?!goog)[A-Za-z][A-Za-z0-9\-_.~+%]{2,254})$" Review Comment: I was reading the GCP docs about subscription naming. Suppose I put a % in the name, but it’s not a valid UTF-8 encoding (like %zzz). What happens in that case? > You can use the special characters in the preceding list in resource names without URL-encoding. However, you must ensure that any other special characters are properly encoded or decoded when you use them in URLs. For example, mi-tópico is an invalid ID. However, mi-t%C3%B3pico is valid. This format is important when you make REST calls. https://cloud.google.com/pubsub/docs/pubsub-basics#resource_names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
