dejii commented on code in PR #54494: URL: https://github.com/apache/airflow/pull/54494#discussion_r2284154665
########## providers/google/src/airflow/providers/google/cloud/queues/pubsub.py: ########## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import re +from typing import TYPE_CHECKING + +from airflow.exceptions import AirflowOptionalProviderFeatureException +from airflow.providers.google.cloud.triggers.pubsub import PubsubPullTrigger + +try: + from airflow.providers.common.messaging.providers.base_provider import BaseMessageQueueProvider +except ImportError: + raise AirflowOptionalProviderFeatureException( + "This feature requires the 'common.messaging' provider to be installed in version >= 1.0.1." + ) + +if TYPE_CHECKING: + from airflow.triggers.base import BaseEventTrigger + +# [START queue_regexp] +QUEUE_REGEXP = ( + r"^projects/(?P<project_id>[^/]+)/subscriptions/" + r"(?P<subscription>(?!goog)[A-Za-z][A-Za-z0-9\-_.~+%]{2,254})$" Review Comment: It works as long as the subscription name starts with a letter. For example, `abc-%zzz` is valid (I confirmed by creating one). However, if you need to interact directly with the REST APIs, the % must be encoded e.g. `abc-%25zzz`. For this provider implementation, URL encoding isn’t required since we interact with the Pub/Sub client libraries. I was able to use: ```python trigger = MessageQueueTrigger( queue="projects/my-project/subscriptions/abc-%zzz" ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
