dejii commented on PR #54494: URL: https://github.com/apache/airflow/pull/54494#issuecomment-3205857649
Hi :) > also I have some questions: are we sure we want to keep this name? it can be confusing for users why we have queue (as a separate service in Google provider), but inside there is still pubsub operators. This structure comes from the implementation details of AIP-82 - it’s how the `common.messaging` provider discovers the available queues. Reference: https://github.com/apache/airflow/blob/b340e8c101c1ed12fb097f9aa5b41bb9c2599275/airflow-core/src/airflow/providers_manager.py#L1097-L1103 https://github.com/apache/airflow/blob/b340e8c101c1ed12fb097f9aa5b41bb9c2599275/providers/common/messaging/src/airflow/providers/common/messaging/triggers/msg_queue.py#L38 > And are you planning to add system tests for this? if yes, can you please explain what should be configured in order to run it? in general in Google provider we are trying to keep every test atomic, so all the configuration and connections that should be used inside the system tests should be created and then deleted in the system test This can be looked into. A Pub/Sub subscription (and implicitly a topic) would be required, but given the way event-driven scheduling works, I’m not sure it can be created and torn down entirely within the scope of a system test as the subscription is what triggers the DAG. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
