ahidalgob commented on PR #62217: URL: https://github.com/apache/airflow/pull/62217#issuecomment-3953031153
> > > @ahidalgob @bugraoz93 > > > Do we have to add a --skip-keyring? > > > Why not just pickup the API key from the environment directly if it is set? > > > Seems like a cleaner way rather than having every command support --skip-keyring? > > > > > > Good point, on a second thought that make more sense! If those are filled, we can auto skip it > > Yup! The cleanest approach would be to pickup the token from env and proceed, else go the keyring route automatically Thanks for the review @dheerajturaga! Just to clarify, here I didn't add the `--skip-keyring` arg to every command, just to `auth login`. I didn't fully like this approach either but the reasoning was to more strongly prefer using the keyring over not using it as it's generally more secure. That said, I'm ok with dropping the `--skip-keyring` flag and just add a warning log during login. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
