ahidalgob commented on code in PR #62217:
URL: https://github.com/apache/airflow/pull/62217#discussion_r2848003152
##########
airflow-ctl/src/airflowctl/ctl/commands/auth_command.py:
##########
@@ -38,7 +38,9 @@ def login(args, api_client=NEW_API_CLIENT) -> None:
success_message = "[green]Login successful! Welcome to airflowctl![/green]"
# Check is username and password are passed
if args.username and args.password:
- # Generate empty credentials with the api_url and env
+ if args.skip_keyring:
Review Comment:
I agree that this use case is wanted. I thought of supporting it in another
PR by adding a new command `auth get-token` so users can run
`AIRFLOW_CLI_TOKEN=$(airflowctl auth get-token)`.
I'm not sure what your suggestion is here "save config without touching
keyring". Where to save it to if not in the keyring and not in a plain-text
file? If we just remove the restriction the token will be fetched but not store
anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
