bugraoz93 commented on PR #62217: URL: https://github.com/apache/airflow/pull/62217#issuecomment-3953563744
> > > > @ahidalgob @bugraoz93 > > > > Do we have to add a --skip-keyring? > > > > Why not just pickup the API key from the environment directly if it is set? > > > > Seems like a cleaner way rather than having every command support --skip-keyring? > > > > > > > > > Good point, on a second thought that make more sense! If those are filled, we can auto skip it > > > > Yup! The cleanest approach would be to pickup the token from env and proceed, else go the keyring route automatically > > Thanks for the review @dheerajturaga @bugraoz93! > > Just to clarify, here I didn't add the `--skip-keyring` arg to every command, just to `auth login`. I didn't fully like this approach either but the reasoning was to more strongly prefer using the keyring over not using it as it's generally more secure. That said, I'm ok with dropping the `--skip-keyring` flag and just add a warning log during login. Thanks @ahidalgob! The idea behind adding api-token to enable this but unfortunately, it couldn't lend it as a full solution. I would be okay in both cases. One is cleaner and other is more aware. As you mentioned, more secure since you cannot skip without being aware clearly. People can use it in their local where keyring exists which this use case made me think adding an option would be better even though it is not the cleanest. In both cases if we print a huge warning and document it clearly, it should be fine. We can also think a bit more and discuss the improvements further as next rather redesigning this solution. Since we are still at 0.x, It should be also okay to do the changes later without concerning much. What do you think? cc: @dheerajturaga -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
