Miretpl commented on code in PR #62544:
URL: https://github.com/apache/airflow/pull/62544#discussion_r2874258506
##########
chart/docs/service-account-token-examples.rst:
##########
@@ -252,46 +239,50 @@ Strict production configuration with enhanced security:
readOnlyRootFilesystem: true
runAsNonRoot: true
+.. note::
+ Remember that it is a good practice to have the production configuration on
the test environment to ensure
+ reliable testing before moving changes to production.
+
Migration Examples
------------------
Gradual Migration from Automatic to Manual
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-Step 1: Test manual configuration alongside automatic (for validation):
+1. Test manual configuration alongside automatic (for validation):
-.. code-block:: yaml
+ .. code-block:: yaml
- # values-test.yaml
- scheduler:
- serviceAccount:
- automountServiceAccountToken: true # Keep automatic for now
- serviceAccountTokenVolume:
- enabled: false # Disable manual for testing
+ # values-test.yaml
Review Comment:
I changed all to 3 spaces as it is stated in the Sphinx doc. It should be
correct across all of the helm doc now (+ I changed some other things - list in
the edit section of PR desc :D)
##########
chart/docs/setting-resources-for-containers.rst:
##########
@@ -42,13 +44,14 @@ Possible Containers where resources can be configured
include:
* ``triggerer.resources``
* ``triggerer.logGroomerSidecar.resources``
-* Containers used for Airflow k8s jobs or cron jobs. You can add the resources
for these Containers through the following parameters:
+* Containers used for Airflow kubernetes jobs or cron jobs. You can add the
resources for these containers through the following parameters:
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
