jscheffl commented on code in PR #62544:
URL: https://github.com/apache/airflow/pull/62544#discussion_r2869503330
##########
chart/docs/service-account-token-examples.rst:
##########
@@ -252,46 +239,50 @@ Strict production configuration with enhanced security:
readOnlyRootFilesystem: true
runAsNonRoot: true
+.. note::
+ Remember that it is a good practice to have the production configuration on
the test environment to ensure
+ reliable testing before moving changes to production.
+
Migration Examples
------------------
Gradual Migration from Automatic to Manual
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-Step 1: Test manual configuration alongside automatic (for validation):
+1. Test manual configuration alongside automatic (for validation):
-.. code-block:: yaml
+ .. code-block:: yaml
- # values-test.yaml
- scheduler:
- serviceAccount:
- automountServiceAccountToken: true # Keep automatic for now
- serviceAccountTokenVolume:
- enabled: false # Disable manual for testing
+ # values-test.yaml
Review Comment:
So actually it was _correct_ before.
##########
chart/docs/service-account-token-examples.rst:
##########
@@ -252,46 +239,50 @@ Strict production configuration with enhanced security:
readOnlyRootFilesystem: true
runAsNonRoot: true
+.. note::
+ Remember that it is a good practice to have the production configuration on
the test environment to ensure
+ reliable testing before moving changes to production.
+
Migration Examples
------------------
Gradual Migration from Automatic to Manual
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-Step 1: Test manual configuration alongside automatic (for validation):
+1. Test manual configuration alongside automatic (for validation):
-.. code-block:: yaml
+ .. code-block:: yaml
- # values-test.yaml
- scheduler:
- serviceAccount:
- automountServiceAccountToken: true # Keep automatic for now
- serviceAccountTokenVolume:
- enabled: false # Disable manual for testing
+ # values-test.yaml
Review Comment:
nit: Don't know why but Sphinx really indents per default by three (3!)
spaces, but 4 are also accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
