jedcunningham commented on code in PR #62544: URL: https://github.com/apache/airflow/pull/62544#discussion_r2874679520
########## chart/docs/adding-connections-and-variables.rst: ########## @@ -20,18 +20,17 @@ Adding Connections, Variables and Environment Variables ======================================================= You can programmatically add Connections, Variables and arbitrary Environment Variables to your -Airflow deployment using the Helm chart. +Airflow deployment using the Helm Chart. Connections and Sensitive Environment Variables ----------------------------------------------- -Under the ``secret`` and ``extraSecret`` sections of the ``values.yaml`` you can pass connection strings and sensitive -environment variables into Airflow using the Helm chart. To illustrate, lets create a yaml file called ``override.yaml`` -to override values under these sections of the ``values.yaml`` file. +Under the ``secret`` and ``extraSecret`` sections of the ``values.yaml``, you can pass connection strings and sensitive +environment variables into Airflow using the Helm Chart. To illustrate, lets create a yaml file called ``overwrite.yaml`` Review Comment: fwiw override is also used in a number of places in the helm docs, and beyond `mergerOverwrite` and `mustMergeOverwrite`, overwrite isn't. I'd argue that you are "overriding" the values (like the whole file is overriding the default values), not a specific value you set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
