Miretpl commented on code in PR #64032:
URL: https://github.com/apache/airflow/pull/64032#discussion_r3012259456
##########
chart/templates/_helpers.yaml:
##########
@@ -1138,7 +1138,7 @@ Usage:
{{- if gt (len $nested) 0 -}}
{{- $_ := set $newValues $key $nested -}}
{{- end -}}
- {{- else if not (eq $val nil) -}}
+ {{- else if $val -}}
Review Comment:
We can not really do that. This function is specifically designed to remove
**ONLY** nil fields (unset), and the behaviour will not always match (e.g. if
the parameter is set to 0, we want to not remove it, but this modification
would result in removing it as 0 is interpreted as false).
Basically, having this modification would require additional logic to be
added, which I believe is not something which we would want to do currently (we
try to simplify the helm chart).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
