Miretpl commented on code in PR #64032:
URL: https://github.com/apache/airflow/pull/64032#discussion_r3012283496


##########
chart/templates/_helpers.yaml:
##########
@@ -1138,7 +1138,7 @@ Usage:
       {{- if gt (len $nested) 0 -}}
         {{- $_ := set $newValues $key $nested -}}
       {{- end -}}
-    {{- else if not (eq $val nil) -}}
+    {{- else if $val -}}

Review Comment:
   Also, based on that function, whole merging of `workers` -> `workers.celery` 
-> `workers.celery.sets` is going on, so with any change here, we need to be 
careful as we could break the Worker Set (whole or in edge cases like mentioned 
above) feature and/or workers rendering in general.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to