Miretpl commented on code in PR #65486:
URL: https://github.com/apache/airflow/pull/65486#discussion_r3107090771
##########
helm-tests/tests/helm_tests/airflow_core/test_worker_sets.py:
##########
@@ -1633,6 +1633,33 @@ def test_overwrite_keda_query(self, workers_values):
assert jmespath.search("spec.triggers[0].metadata.query", docs[0]) ==
"test"
+ @pytest.mark.parametrize(
+ ("queue", "expected_in_query"),
+ [
+ ("cpu", "queue IN ('cpu')"),
+ ("highcpu,highmem", "queue IN ('highcpu','highmem')"),
+ ],
+ )
+ def test_per_set_queue_renders_in_default_keda_query(self, queue,
expected_in_query):
Review Comment:
We could also test here if overwriting of `workers.keda` is working
correctly in that case.
##########
helm-tests/tests/helm_tests/airflow_core/test_worker_sets.py:
##########
@@ -1633,6 +1633,33 @@ def test_overwrite_keda_query(self, workers_values):
assert jmespath.search("spec.triggers[0].metadata.query", docs[0]) ==
"test"
+ @pytest.mark.parametrize(
+ ("queue", "expected_in_query"),
+ [
+ ("cpu", "queue IN ('cpu')"),
+ ("highcpu,highmem", "queue IN ('highcpu','highmem')"),
+ ],
+ )
+ def test_per_set_queue_renders_in_default_keda_query(self, queue,
expected_in_query):
Review Comment:
```suggestion
def test_overwrite_queue_keda_query(self, queue, expected_in_query):
```
to match more with test cases naming inside of this test file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
