Miretpl commented on code in PR #65486:
URL: https://github.com/apache/airflow/pull/65486#discussion_r3107389244
##########
helm-tests/tests/helm_tests/airflow_core/test_worker_sets.py:
##########
@@ -1633,6 +1633,33 @@ def test_overwrite_keda_query(self, workers_values):
assert jmespath.search("spec.triggers[0].metadata.query", docs[0]) ==
"test"
+ @pytest.mark.parametrize(
+ ("queue", "expected_in_query"),
+ [
+ ("cpu", "queue IN ('cpu')"),
+ ("highcpu,highmem", "queue IN ('highcpu','highmem')"),
+ ],
+ )
+ def test_per_set_queue_renders_in_default_keda_query(self, queue,
expected_in_query):
Review Comment:
It depends on how you look at it. In general, the proposed test case in this
PR is also covered by tests in the dedicated `test_keda.py` file, with
overwrite tests in `test_workers.py` and this file, but it is tested more
indirectly, and an error message in case these tests fail would not be clear. I
think the same goes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
