Miretpl commented on code in PR #65486:
URL: https://github.com/apache/airflow/pull/65486#discussion_r3112960640


##########
helm-tests/tests/helm_tests/airflow_core/test_worker_sets.py:
##########
@@ -1633,6 +1633,46 @@ def test_overwrite_keda_query(self, workers_values):
 
         assert jmespath.search("spec.triggers[0].metadata.query", docs[0]) == 
"test"
 
+    @pytest.mark.parametrize("parent_path", ["deprecated", "modern"])
+    @pytest.mark.parametrize("enable_default", [False, True])

Review Comment:
   These two options, when looking inside the tests, add a lot of complexity to 
the test case, which, in case of errors, will make debugging harder. Can we 
split this test case to reduce its complexity?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to