jscheffl commented on code in PR #63932:
URL: https://github.com/apache/airflow/pull/63932#discussion_r3120344678
##########
providers/edge3/src/airflow/providers/edge3/models/edge_worker.py:
##########
@@ -180,90 +180,32 @@ def set_metrics(
"free_concurrency",
}
- if AIRFLOW_V_3_2_PLUS:
Review Comment:
Mhm, I am not sure, even if we rated `DualStatsManager` being an internal
and nto public API it was used at least for one release of the providers to be
be compatible with Airflow 3.2.0 and 3.2.1.
If we move this to use common-compat now this is fine... in future versions.
But if the (last) Edge provider release is used with Airflow 3.2.2 then the
interface is missing and breaking the provider?
How did we treat this in other cases where forward core versions against
"older" providers break compatibility? Do we need to have at least some compat
shim even if we decided not having this public API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
