xBis7 commented on code in PR #63932:
URL: https://github.com/apache/airflow/pull/63932#discussion_r3123202414
##########
providers/edge3/src/airflow/providers/edge3/models/edge_worker.py:
##########
@@ -180,90 +180,32 @@ def set_metrics(
"free_concurrency",
}
- if AIRFLOW_V_3_2_PLUS:
Review Comment:
It was discussed on a previous community call and the conclusion was that if
the pattern is
```
try:
...
except ImportError:
...
```
then we are safe to remove it. But if the pattern is
```
if AIRFLOW_V_X_X_PLUS:
...
else:
...
```
then we are locked and we need to support it for 3 minor releases after the
version on the check.
During the time of the call, it was with the `try-except` pattern but now I
guess we have to maintain it somehow.
Maybe it will be a no-op shim that will underneath call the new code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
