xBis7 commented on code in PR #63932:
URL: https://github.com/apache/airflow/pull/63932#discussion_r3124926495
##########
providers/edge3/src/airflow/providers/edge3/models/edge_worker.py:
##########
@@ -180,90 +180,32 @@ def set_metrics(
"free_concurrency",
}
- if AIRFLOW_V_3_2_PLUS:
Review Comment:
Hey @jscheffl, I added back the `dual_stats_manager.py` in the same location
that it existed. It still gets re-exported from the sdk and can be accessed
from the old import. The file has been converted into a shim that calls the new
interface.
It was released in the edge3 provider 3.4.0 with a version check
```
if AIRFLOW_V_3_2_PLUS:
```
which means that as long as that provider version is used, it will expect
the `DualStatsManager` to exist for any version of `airflow-core` >= 3.2.0. I
think the shim can only be removed once the edge3 3.4.0 version stops being
supported.
https://github.com/xBis7/airflow/blob/8ea0a2a065213f0a9b7c0c6779501dc3fcf9995d/shared/observability/src/airflow_shared/observability/metrics/dual_stats_manager.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
