Subham-KRLX commented on code in PR #64051:
URL: https://github.com/apache/airflow/pull/64051#discussion_r3177734881
##########
providers/airbyte/src/airflow/providers/airbyte/operators/airbyte.py:
##########
@@ -129,6 +144,22 @@ def execute_complete(self, context: Context, event: Any =
None) -> None:
self.log.debug("Error occurred with context: %s", context)
raise RuntimeError(event["message"])
+ if event["status"] == "cancelled":
+ self.log.debug("Job cancelled with context: %s", context)
+ raise RuntimeError(event["message"])
+
+ job_id = event.get("job_id")
+ if event["status"] == "timeout":
Review Comment:
If cancel_job raises the exception propagates and the timeout error is lost
the caller won't know why the task failed wrap in try/except log the
cancellation failure then raise the timeout error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
