Subham-KRLX commented on code in PR #64051:
URL: https://github.com/apache/airflow/pull/64051#discussion_r3177736300
##########
providers/airbyte/src/airflow/providers/airbyte/triggers/airbyte.py:
##########
@@ -62,15 +67,29 @@ def serialize(self) -> tuple[str, dict[str, Any]]:
"conn_id": self.conn_id,
"end_time": self.end_time,
"poll_interval": self.poll_interval,
+ "execution_deadline": self.execution_deadline,
},
)
async def run(self) -> AsyncIterator[TriggerEvent]:
"""Make async connection to Airbyte, polls for the pipeline run
status."""
hook = AirbyteHook(airbyte_conn_id=self.conn_id)
try:
- while await self.is_still_running(hook):
- if self.end_time < time.time():
+ while True:
+ now = time.time()
Review Comment:
time.time() can jump on NTP sync use time.monotonic() for duration checks
same fix needed in the operator where end_time and execution_deadline are
computed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
