SameerMesiah97 commented on code in PR #64051:
URL: https://github.com/apache/airflow/pull/64051#discussion_r3178583753
##########
providers/airbyte/src/airflow/providers/airbyte/operators/airbyte.py:
##########
@@ -129,6 +144,22 @@ def execute_complete(self, context: Context, event: Any =
None) -> None:
self.log.debug("Error occurred with context: %s", context)
raise RuntimeError(event["message"])
+ if event["status"] == "cancelled":
+ self.log.debug("Job cancelled with context: %s", context)
+ raise RuntimeError(event["message"])
+
+ job_id = event.get("job_id")
+ if event["status"] == "timeout":
Review Comment:
Best-effort cancellation (as well as it's associated test) has been
re-introduced for the timeout block to address this. The exception will now be
caught and logged. And the original timeout error will now be raised.
To ensure symmetry, best-effort cancellation (as well as a new test) has
been introduced for the `on_kill` method too. Please refer to the previous
review by @kaxil for more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
