wilmerdooley commented on code in PR #67664:
URL: https://github.com/apache/airflow/pull/67664#discussion_r3343934174
##########
airflow-core/src/airflow/ui/src/pages/Dashboard/HistoricalMetrics/TaskInstanceMetrics.tsx:
##########
@@ -70,6 +74,7 @@ export const TaskInstanceMetrics = ({
<MetricSection
capped={taskInstanceStates[state] >= stateCountLimit}
endDate={endDate}
+ isCapped={isCapped}
Review Comment:
This one started out as totalCapped, and I changed it to isCapped from
@bbovenzi's earlier suggestion
(https://github.com/apache/airflow/pull/67664#discussion_r3335744404). Happy to
switch it back to totalCapped, which keeps it visibly distinct from the per
state capped and matches the wording in the description.
They are two different values: capped is per state (this state's own count
is at the limit, which drives the N+ badge and the full width bar), while the
group flag is true when any state is at the limit, so the summed total is
unreliable and the percentages are hidden for the whole group.
Let me know which name you both prefer and I will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
