wilmerdooley commented on code in PR #67664:
URL: https://github.com/apache/airflow/pull/67664#discussion_r3353556488
##########
airflow-core/src/airflow/ui/src/pages/Dashboard/HistoricalMetrics/TaskInstanceMetrics.tsx:
##########
@@ -70,6 +74,7 @@ export const TaskInstanceMetrics = ({
<MetricSection
capped={taskInstanceStates[state] >= stateCountLimit}
endDate={endDate}
+ isCapped={isCapped}
Review Comment:
Done. Renamed the group-level flag to `isTotalTruncated` (the name @bbovenzi
suggested) across `MetricSection`, `TaskInstanceMetrics`, and `DagRunMetrics`,
and simplified the suppression to `const hidePercent = isTotalTruncated`,
dropping the redundant `capped ||` since a capped state already implies the
group total is truncated. The per-state `capped` prop is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
