pierrejeambrun commented on code in PR #67664:
URL: https://github.com/apache/airflow/pull/67664#discussion_r3347038924
##########
airflow-core/src/airflow/ui/src/pages/Dashboard/HistoricalMetrics/TaskInstanceMetrics.tsx:
##########
@@ -70,6 +74,7 @@ export const TaskInstanceMetrics = ({
<MetricSection
capped={taskInstanceStates[state] >= stateCountLimit}
endDate={endDate}
+ isCapped={isCapped}
Review Comment:
Rename to something that convey the information that this is a group/global
capped.
`const hidePercent = capped || isCapped; // capped || isCapped ===
isCapped`
Remove the `capped`. (if state is capped, then `isCapped` is True, the group
is capped)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
