nathadfield commented on PR #67285:
URL: https://github.com/apache/airflow/pull/67285#issuecomment-4649671460

   > so `{{ partition_date }}` will be partition_date for a DagRun not for 
AssetEvent. it might differ if we use a RollupMapper
   
   Good point, @Lee-W. `{{ partition_date }}` is the consumer DagRun's date, 
and a `RollupMapper` collapses n upstream partitions (each with its own date) 
into one downstream partition, so no single source date describes the window. 
I've made `_compute_target_partition_date` return `None` for `RollupMapper` 
(explicit `is_rollup` guard plus a unit test), so rollup consumers get 
`partition_date=None` rather than an arbitrary first-event value and fall back 
to `partition_key`. Documented alongside the other mappers that leave it `None`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to