nathadfield commented on PR #67285: URL: https://github.com/apache/airflow/pull/67285#issuecomment-4669359179
Thanks @Lee-W , that's helpful context. Agreed on the type switch: I'll leave the `is_rollup/isinstance` branching in `_compute_target_partition_date` as-is here and let your polymorphic to_partition_date replace it once that lands, rather than couple this PR to an unmerged API. From your list I'll keep on this side: the `IdentityMapper` passthrough (its key can't reconstruct a date, so the threaded source date is still needed), `Context["partition_date"]`, the execution-API field plus Cadwyn versioning, `DAGRunResponse`, and the docs. That leaves your PR to own the scheduler-side `DagRun.partition_date` stamping for rollup, fan-out, and chain. Same on `RollupMapper`: I've documented it as None here for now, and #68266 can relax that for the cases where a rolled-up window has a well-defined date. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
