Lee-W commented on code in PR #67285:
URL: https://github.com/apache/airflow/pull/67285#discussion_r3374302339
##########
airflow-core/docs/migrations-ref.rst:
##########
@@ -39,7 +39,10 @@ Here's the list of all the Database Migrations that are
executed via when you ru
+-------------------------+------------------+-------------------+--------------------------------------------------------------+
| Revision ID | Revises ID | Airflow Version | Description
|
+=========================+==================+===================+==============================================================+
-| ``9ff64e1c35d3`` (head) | ``dd5f3a8e2b91`` | ``3.3.0`` | Add indexes
on dag_run.created_dag_version_id and |
+| ``d2f4e1b3c5a7`` (head) | ``9ff64e1c35d3`` | ``3.3.0`` | Add
partition_date to asset_event and |
Review Comment:
I'd lean toward dropping the column and re-deriving via the source DagRun.
* It's an indexed `(source_dag_id, source_run_id)` lookup, only for the
IdentityMapper subset, batchable into one IN query per tick.
* *The consumer DagRun already copies partition_date at creation, so once
the run exists, it's self-contained regardless.
* That leaves only one thing the column buys: an IdentityMapper source date
surviving on AssetEventResponse after the producer run is pruned — which I
think is an acceptable edge case to return None for, rather than a permanent
column on asset_event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
