amoghrajesh commented on code in PR #68067:
URL: https://github.com/apache/airflow/pull/68067#discussion_r3393319901
##########
providers/apache/spark/src/airflow/providers/apache/spark/operators/spark_submit.py:
##########
@@ -290,9 +301,23 @@ def execute(self, context: Context) -> None:
return self.get_job_result(driver_id, context)
hook.submit(self.application)
- def submit_job(self, context: Context) -> str:
+ def submit_job(self, context: Context) -> str | None:
if self._hook is None:
self._hook = self._get_hook()
+ if self._hook._is_kubernetes:
+ self._hook._conf[_K8S_WAIT_APP_COMPLETION_CONF] = "false"
+ self._hook.submit(self.application)
+ pod_name = self._hook._kubernetes_driver_pod
+ namespace = self._hook._connection["namespace"]
+ if not pod_name:
+ self.log.warning(
+ "spark-submit did not capture a K8s driver pod name; "
+ "crash recovery will not be available for this run"
+ )
+ return None
Review Comment:
Good catch. Changed to raise RuntimeError immediately, consistent with the
YARN branch. Updated the test accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
