amoghrajesh commented on code in PR #68067:
URL: https://github.com/apache/airflow/pull/68067#discussion_r3407861582


##########
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -1225,6 +1243,7 @@ def _poll_k8s_driver_via_api(self) -> None:
                     consecutive_unknown = 0
                 time.sleep(poll_interval)
             self._delete_driver_pod()

Review Comment:
   Good point. If _delete_driver_pod raises for whatever reason, the exception 
propagates out and skips the terminal_phase return, which means the task_store 
write is missed and the task fails unnecessarily. Wrapped it as suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to