jason810496 commented on code in PR #68067:
URL: https://github.com/apache/airflow/pull/68067#discussion_r3400832777
##########
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -1225,6 +1243,7 @@ def _poll_k8s_driver_via_api(self) -> None:
consecutive_unknown = 0
time.sleep(poll_interval)
self._delete_driver_pod()
Review Comment:
I would prefer to have with `contextlib.suppress` surrounding the
`self._delete_driver_pod()`. Just in case of unexpect exception raise when
deleteing the driver pod then we need to retry the whole job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
