fat-catTW opened a new pull request, #71546:
URL: https://github.com/apache/airflow/pull/71546
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Why
`GlueJobOperator` can reconnect to a previously submitted Glue job run on
retry by tagging the Glue run arguments with the Airflow task UUID and later
scanning `GetJobRuns` for that UUID.
That fallback is useful when the operator does not have a stored Glue run
id, but the no-match case currently has no upper bound. If a Glue job has a
long run history, a retry can keep paginating through the full history before
deciding to submit a fresh run.
The reconnect lookup also catches broad exceptions. That can hide non-AWS
bugs and make AWS lookup failures harder to diagnose, because the operator may
continue by submitting a new Glue job run and surface a later error such as
`ConcurrentRunsExceededException`.
relates: #71489
## Solution
Bound the task UUID fallback scan to 10 `GetJobRuns` pages. The scan keeps
the existing page size of 50 runs, so a retry checks at most 500 recent Glue
job runs before treating the previous run as not found.
This keeps the reconnect path useful for normal retry and crash-recovery
cases while preventing an unbounded walk through the full Glue job history when
there is no match.
Also narrow reconnect lookup exception handling to AWS `ClientError`. These
failures are now logged with exception details, while non-AWS errors bubble up
instead of being swallowed.
Finally, update the Glue operator documentation to mention that this retry
fallback requires `glue:GetJobRuns`, in addition to the usual Glue job run
permissions.
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- `[X]` Yes (please specify the tool below)
Generated-by: [Codex] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
