pierrejeambrun commented on PR #73437:
URL: https://github.com/apache/airflow/pull/73437#issuecomment-5797176417

   @ash TS SDK: Retrieve task id from fn name via a plugin to manipulate the 
source before packaging.
   
   Since this adds some complexity, I'm second guessing if keepNames (basically 
not minifying names) was a best option
   
   - Would remove most of this code
   - Would allow for cleaner debug process, with stack traces pointing to real 
function names instead of minified ones
    - This shouldn't matter in term of 'size', the workers are already pulling 
tons of dependencies (python stuff), a few extra names shouldn't be that bad. 
And it shouldn't have a meaningful impact on execution speed as well.
   
   Also common node recommendation for server side is typically not to minify 
at all. (keepNames can meet best of both world).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to