pierrejeambrun commented on code in PR #73437:
URL: https://github.com/apache/airflow/pull/73437#discussion_r4093473868
##########
ts-sdk/src/sdk/dag.ts:
##########
@@ -560,6 +632,54 @@ function spreadArgs(fn: TaskFunction): TaskFunction {
handler(...Object.values(args ?? {}))) as unknown as TaskFunction;
}
+// What Airflow accepts as a task id, and so what a name taken from a handler
+// has to look like.
+const TASK_ID_CHARACTERS = /^[\p{L}\p{N}_.-]+$/u;
Review Comment:
TS is still more permissive than python sdk:
- 255 max length enforced on the python side
- no check on config `allow_double_dot_in_ids` for `..`
Meaning that a 'bad' id can make it into the db. Should we move that
validation on the server side so all sdks can leverage this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
