ashb commented on code in PR #73763:
URL: https://github.com/apache/airflow/pull/73763#discussion_r4122581918
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/backfills.py:
##########
@@ -44,6 +44,13 @@ class BackfillPostBody(StrictBaseModel):
"then the ``[core] rerun_with_latest_version`` config option, "
"and finally ``True`` (the historical default for backfills).",
)
+ drain_dag: bool = Field(
+ default=False,
+ description="Put the Dag into the draining state so the backfill
executes without resuming the "
+ "schedule. The Dag pauses once all of its unfinished runs finish, and
any runs already queued "
+ "on a paused Dag start as well. Requires the same permission as
pausing the Dag. Ignored by the "
Review Comment:
I don't think this feature should be built on top of drain for exactly this
gotcha.
If you currently have a dag with unfinished runs paused, this would
implicitly, and perhaps to the user unexpectedly continue those runs to. The UI
option is called **Run without resuming the schedule** - having that also start
running other currently paused runs feels like a suprise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
