kaxil commented on code in PR #73763: URL: https://github.com/apache/airflow/pull/73763#discussion_r4122899521
########## airflow-core/docs/core-concepts/dags.rst: ########## @@ -813,6 +815,16 @@ the scheduler automatically changes the Dag to paused. A backfill started while the drain until its Dag runs have been created and finished. While a Dag is draining, you can cancel the drain to make the Dag active again. +To execute a manual run, backfill or asset materialization on a paused Dag without resuming its schedule, Review Comment: **The form also mixes up the Dag's switch with the Dag's state.** Active and paused are the switch the user sets. Draining is a temporary state the Dag passes through on its way to paused. "Run without resuming the schedule" reads like an option on this one run, but what it actually does I think, (correct me if I am wrong), is change the Dag's state, and the effect covers the whole Dag: every queued run that the pause was holding back starts too (Ash's point above). "Unpause on trigger" also changes the Dag from this form, but its label says so. If this is built on drain, I'd like: 1. The title, docs and newsfragment to describe it as draining the Dag, e.g. "Allow explicit runs to drain a paused Dag". 2. The option to be named for what it does to the Dag, with the consequence up front, e.g. "Drain the Dag: no new scheduled runs, queued runs start, then it pauses again". 3. No "paused, but ..." path in the scheduler or the API, so the only thing that lets a run start is the Dag not being paused. That's also why I'd rather not add a per-run override flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
