aoelvp94 commented on code in PR #73015:
URL: https://github.com/apache/airflow/pull/73015#discussion_r4491278981
##########
providers/amazon/src/airflow/providers/amazon/aws/bundles/s3.py:
##########
@@ -62,11 +76,20 @@ def __init__(
bundle_name=self.name,
version=self.version,
bucket_name=self.bucket_name,
- prefix=self.prefix,
aws_conn_id=self.aws_conn_id,
+ **self._log_fields(),
Review Comment:
Subclasses now override `_get_logger()` and return a fully bound logger; the
base supplies the shared bindings.
https://github.com/aoelvp94/airflow/commit/d1017581b4e5e42d8a5b5632f03f88fefc17ad45
##########
providers/amazon/src/airflow/providers/amazon/aws/bundles/s3.py:
##########
@@ -163,7 +150,215 @@ def view_url_template(self) -> str | None:
if self.s3_hook.region_name:
url += f".{self.s3_hook.region_name}"
url += ".amazonaws.com"
- if self.prefix:
- url += f"/{self.prefix}"
+ key = self._view_url_key()
+ if key:
+ url += f"/{key}"
return url
+
+ def _reject_version_refresh(self) -> None:
+ if self.version:
+ raise AirflowException("Refreshing a specific version is not
supported")
Review Comment:
Dropped the redundant `_require_tar_data_filter()` call in
`_extract_archive`; the constructor already enforces it.
https://github.com/aoelvp94/airflow/commit/602dc7b533f2b4732dc4bcb78a6f716731fc4d16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
